Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPSEXP-2880 Add audit-storage role #996

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Conversation

gionn
Copy link
Member

@gionn gionn commented Nov 26, 2024

@gionn gionn self-assigned this Nov 26, 2024
@gionn gionn changed the title OPSEXP-2880 Add audit-storage and systemd-service roles OPSEXP-2880 Add audit-storage role Nov 27, 2024
@gionn gionn marked this pull request as ready for review November 27, 2024 13:42
pmacius
pmacius previously approved these changes Nov 28, 2024
Copy link
Contributor

@pmacius pmacius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we disabling this role for older version?

@gionn
Copy link
Member Author

gionn commented Nov 28, 2024

Are we disabling this role for older version?

good catch, let me add an explicit validation for that

@gionn gionn requested a review from pmacius November 29, 2024 09:34
@gionn gionn added the ec2-test Triggers ec2 integrations tests label Nov 29, 2024
Copy link
Contributor

@pmacius pmacius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can bump dtas version to v1.6.0 and configure tests for audit-storage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ec2-test Triggers ec2 integrations tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants